advancedxy commented on code in PR #8001:
URL: https://github.com/apache/iceberg/pull/8001#discussion_r1274973393
##########
.palantir/revapi.yml:
##########
@@ -774,6 +774,15 @@ acceptedBreaks:
- code: "java.method.removed"
old: "method org.apache.iceberg.view.ViewBuilder
org.apache.iceberg.view.ViewBuilder::withQueryColumnNames(java.util.List<java.lang.String>)"
justification: "Acceptable break due to updating View APIs and the View
Spec"
+ org.apache.iceberg:iceberg-core:
Review Comment:
+1, I think it might be unnecessary to rename the method here if you are
just going to lock the commit stage.
For example, you can lock in the commitReadyCommitGroups:
```
if (batch != null) {
String inProgressCommitToken = UUID.randomUUID().toString();
inProgressCommits.add(inProgressCommitToken);
try {
// add lock here
commitOrClean(batch);
// release the lock
committedRewrites.addAll(batch);
} catch (Exception e) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
