rdblue commented on code in PR #7032:
URL: https://github.com/apache/iceberg/pull/7032#discussion_r1268289514
##########
core/src/main/java/org/apache/iceberg/TableMetadataParser.java:
##########
@@ -299,7 +299,7 @@ public static TableMetadata fromJson(String
metadataLocation, String json) {
return JsonUtil.parse(json, node ->
TableMetadataParser.fromJson(metadataLocation, node));
}
- static TableMetadata fromJson(InputFile file, JsonNode node) {
+ public static TableMetadata fromJson(InputFile file, JsonNode node) {
Review Comment:
@Fokko, @snazy, I think we need to revert this. We cannot leak Jackson
classes publicly through an Iceberg API, even in core.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
