bryanck commented on code in PR #6906: URL: https://github.com/apache/iceberg/pull/6906#discussion_r1268222121
##########
python/mkdocs/docs/configuration.md:
##########
@@ -73,7 +73,22 @@ For the FileIO there are several configuration options
available:
| adlfs.sas-token | NuHOuuzdQN7VRM%2FOpOeqBlawRCA845IY05h9eu1Yte4%3D
| The shared access signature
|
| adlfs.tenant-id | ad667be4-b811-11ed-afa1-0242ac120002
| The tenant-id
|
| adlfs.client-id | ad667be4-b811-11ed-afa1-0242ac120002
| The client-id
|
-| adlfs.client-secret | oCA3R6P\*ka#oa1Sms2J74z...
| The client-secret
|
+| adlfs.client-secret | oCA3R6P\*ka#oa1Sms2J74z...
| The client-secret
|
+
+### Google Cloud Storage
Review Comment:
It would be nice if the Python GCS properties could be consistent with the
Java properties where possible. Java already has some properties defined so
starting with those would help avoid any backwards compatibility issues (rather
than changing them). There is also a
[PR](https://github.com/apache/iceberg/pull/8073) to add OAuth2 access token
properties on the Java side.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
