MaxNevermind commented on code in PR #7694:
URL: https://github.com/apache/iceberg/pull/7694#discussion_r1262085142
##########
spark/v3.2/build.gradle:
##########
@@ -60,11 +56,11 @@
project(":iceberg-spark:iceberg-spark-${sparkMajorVersion}_${scalaVersion}") {
implementation project(':iceberg-orc')
implementation project(':iceberg-parquet')
implementation project(':iceberg-arrow')
-
implementation("org.scala-lang.modules:scala-collection-compat_${scalaVersion}")
+ implementation
"org.scala-lang.modules:scala-collection-compat_${scalaVersion}:2.6.0"
Review Comment:
> why do we need the 2.6.0 now?
I actually was present before, you can find version declaration in
versions.props in master
> or should this be using scalaCollectionCompat?
because it's dynamic and uses scalaVersion we can't just replace it with
libs.scala.collection.compat
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
