MaxNevermind commented on code in PR #7694: URL: https://github.com/apache/iceberg/pull/7694#discussion_r1262057123
########## gradle/libs.versions.toml: ########## @@ -0,0 +1,153 @@ +# Also see settings.gradle file for dynamic versionCatalogs dependencies + +[versions] +antlr = "4.9.3" +deltaStandalone = "0.6.0" Review Comment: done note that I still avoided usage of version naming that contain part consisting of just numbers, I'm not sure that this idiomatic way of doing that, I checked it does work but IDE doesn't support that and jump to definitions stops working, though something like spark-hive-v31 should work let me know what you think, Ideally it would be nice to see a version separately and also separate version into a major and minor versions parts, spark-hive-3-1 but as I said it does break current IDE support, at least in InteliJ Idea -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
