ndimiduk commented on PR #8757: URL: https://github.com/apache/hbase/pull/8757#issuecomment-6270586069
The new code will now do bounded read enforcement rather than just returning whatever bytes from memory happened to be present. It's possible that we have some bugs about this lurking, but I doubt it. For callers, there's the possibility of an `IndexOutOfBoundsException`. Is it worth adding a test for this over in `BytesTestBase.java`; what's there uses on-heap buffers. > and the performance is similar Can you be more precise about this? Performance has always been the lurking concern around this change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
