kgeisz commented on code in PR #8770:
URL: https://github.com/apache/hbase/pull/8770#discussion_r4275686994
##########
dev-support/read-replica/run_read_replica_integration_tests.sh:
##########
@@ -259,6 +259,18 @@ cleanup() {
fi
echo "=== Cleanup: Deleting copied HBase directory: ${REPLICA_DIR}/hbase ==="
rm -rf "${REPLICA_DIR}/hbase"
+ echo "=== Cleanup: Deleting artifacts that would be owned by root on the CI
host ==="
+ rm -rf "${REPLICA_DIR}/.venv"
+ rm -rf "${REPLICA_DIR}/.pytest_cache"
+ rm -rf "${REPLICA_DIR}/python/test/.pytest_cache"
+ rm -rf "${REPLICA_DIR}/python/__pycache__"
+ rm -rf "${REPLICA_DIR}/python/test/__pycache__"
+ rm -rf "${REPLICA_DIR}/python/src/__pycache__"
+ rm -rf "${REPLICA_DIR}/python/proto/generated"
+ rm -rf "${REPLICA_DIR}/python/proto/ActiveClusterSuffix.proto"
+ rm -rf "${REPLICA_DIR}/tmp-read-replica-data"
+ rm -rf "${REPLICA_DIR}/cluster1/logs"
+ rm -rf "${REPLICA_DIR}/cluster2/logs"
Review Comment:
The `rm` commands here remove left over artifacts from the test run that
have `root` ownership. The test will pass whether these are removed or not.
It's useful for the next Jenkins run. If `Wipe out repository & force clone`
is enabled in the pipeline, then the subsequent run will try to wipe the
`component` directory (which is basically the `hbase` dir). If these
`root`-owned artifacts are still there, then the deletion will fail and the
Jenkins run will fail almost immediately because the `jenkins` user cannot
remove files/dirs owned by `root`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
