PDavid commented on code in PR #8681:
URL: https://github.com/apache/hbase/pull/8681#discussion_r4133130719
##########
hbase-common/src/main/java/org/apache/hadoop/hbase/io/crypto/tls/X509Util.java:
##########
@@ -278,6 +279,44 @@ public static char[] resolvePassword(Configuration config,
String roleKey, Strin
return value;
}
+ // resolveConfig falls back per key, so a store whose location comes from
one prefix and whose
+ // password/type come from the other would open the wrong file, or the right
file with the wrong
+ // credentials. A store is a unit: reject configs that straddle both
prefixes.
+ public static void validateConfigPrefixConsistency(Configuration config,
String rolePrefix,
Review Comment:
Many thanks for adding this method which checks the consistency. 👍 Would it
maybe make sense to add unit test for this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
