lucakovacs commented on PR #8681: URL: https://github.com/apache/hbase/pull/8681#issuecomment-5869395583
I made the following changes according to @petersomogyi's review: - Changed the SSLException to IOException in the TestRESTServerSSL.java file - Deleted the two tests in TestX509Util.java since after the no-op code was removed the remaining parts are covered in other tests. - Deleted testClientAuthModeKeyIsRoleScoped() in TestInfoServerTLSConfig.java since it’s not testing any functional behaviour - Added a helper method validateClientAuthTrustStore to avoid Jetty’s fallback mechanism in Thrift/InfoServer/REST when no truststore is set. Also added tests to test the validation - Added inline expressions for Thrift/REST/Infoserver when resolving client auth mode to avoid whitespace resolved as NEED - Added a config validator method for checking mixed role configuration If acceptable, I would to the documentation on an other PR or JIRA if needed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
