Apache9 commented on code in PR #7947:
URL: https://github.com/apache/hbase/pull/7947#discussion_r2969664493
##########
hbase-server/src/test/java/org/apache/hadoop/hbase/filter/FilterTestingCluster.java:
##########
@@ -94,21 +89,20 @@ private static void initialize(Configuration conf) {
try {
admin = TEST_UTIL.getAdmin();
} catch (MasterNotRunningException e) {
- assertNull("Master is not running", e);
+ assertNull(e, "Master is not running");
} catch (ZooKeeperConnectionException e) {
- assertNull("Cannot connect to ZooKeeper", e);
+ assertNull(e, "Cannot connect to ZooKeeper");
} catch (IOException e) {
- assertNull("IOException", e);
+ assertNull(e, "IOException");
}
}
- @BeforeClass
Review Comment:
No BeforeAll?
##########
hbase-server/src/test/java/org/apache/hadoop/hbase/filter/FilterTestingCluster.java:
##########
@@ -36,40 +36,35 @@
import org.apache.hadoop.hbase.client.Table;
import org.apache.hadoop.hbase.client.TableDescriptor;
import org.apache.hadoop.hbase.client.TableDescriptorBuilder;
-import org.apache.hadoop.hbase.testclassification.FilterTests;
-import org.apache.hadoop.hbase.testclassification.MediumTests;
import org.apache.hadoop.hbase.util.Bytes;
-import org.junit.AfterClass;
-import org.junit.BeforeClass;
-import org.junit.experimental.categories.Category;
+import org.junit.jupiter.api.AfterAll;
/**
* By using this class as the super class of a set of tests you will have a
HBase testing cluster
* available that is very suitable for writing tests for scanning and
filtering against.
*/
-@Category({ FilterTests.class, MediumTests.class })
Review Comment:
Missing Tag?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
