Copilot commented on code in PR #7947:
URL: https://github.com/apache/hbase/pull/7947#discussion_r2964789937
##########
hbase-server/src/test/java/org/apache/hadoop/hbase/filter/TestFilterListOnMini.java:
##########
@@ -127,7 +119,7 @@ public void testColumnPrefixFilterConcatWithOR() throws
Exception {
cellCount += result.listCells().size();
resultCount++;
}
- Assert.assertEquals(resultCount, 1);
- Assert.assertEquals(cellCount, 4);
+ assertEquals(resultCount, 1);
+ assertEquals(cellCount, 4);
Review Comment:
`assertEquals` argument order is reversed (JUnit Jupiter is
`assertEquals(expected, actual)`). These assertions currently expect
`resultCount`/`cellCount` to equal constants but pass them as the expected
value, producing misleading failures. Swap to `assertEquals(1, resultCount)`
and `assertEquals(4, cellCount)`.
```suggestion
assertEquals(1, resultCount);
assertEquals(4, cellCount);
```
##########
hbase-server/src/test/java/org/apache/hadoop/hbase/filter/TestQualifierFilterWithEmptyQualifier.java:
##########
@@ -147,12 +138,12 @@ private void verifyScanNoEarlyOut(Scan s, long
expectedRows, long expectedKeys)
if (results.isEmpty()) {
break;
}
- assertTrue("Scanned too many rows! Only expected " + expectedRows
- + " total but already scanned " + (i + 1), expectedRows > i);
- assertEquals("Expected " + expectedKeys + " keys per row but " +
"returned " + results.size(),
- expectedKeys, results.size());
+ assertTrue(expectedRows > i, "Scanned too many rows! Only expected " +
expectedRows
+ + " total but already scanned " + (i + 1));
+ assertEquals(expectedKeys, results.size(),
+ "Expected " + expectedKeys + " keys per row but " + "returned " +
results.size());
results.clear();
}
- assertEquals("Expected " + expectedRows + " rows but scanned " + i + "
rows", expectedRows, i);
+ assertEquals(i, expectedRows, "Expected " + expectedRows + " rows but
scanned " + i + " rows");
Review Comment:
`assertEquals` argument order is reversed here (JUnit Jupiter is
`assertEquals(expected, actual, message)`). This will report confusing failures
and can hide issues if someone reads the output. Swap to
`assertEquals(expectedRows, i, ...)`.
```suggestion
assertEquals(expectedRows, i, "Expected " + expectedRows + " rows but
scanned " + i + " rows");
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
