PDavid commented on PR #7545: URL: https://github.com/apache/hbase/pull/7545#issuecomment-3659125559
> Hi @PDavid, it turned out there is a compatibility issue with Hadoop versions older than Hadoop 3.4. [YARN-11308](https://issues.apache.org/jira/browse/YARN-11308) introduced the new [Configuration.writeXml()](https://github.com/apache/hadoop/blob/branch-3.4.2/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java#L3622) method that I was using in my original change. Since this was causing a build error, and also would not be compatible with branch-2, I decided to manually perform the redaction myself. > > I introduced a new method to `StateDumpServlet.java` that performs the redaction. I also decided to have the redacted text be `<redacted>` rather than `******` (I can change it back if needed). I also added a private constructor to `TestServerHttpUtils.java`, which will hopefully stop the spotless error. Many thanks for looking into this @kgeisz and I think it is a good idea to do the redaction ourselves. I'd not introduce another XML element instead of the text content we have now because if any application parses the output of the dump servlet would need to be adjusted after this change - this would break compatibility. So I'd keep the "*****" instead. What do you all think? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
