stoty commented on code in PR #7545:
URL: https://github.com/apache/hbase/pull/7545#discussion_r2616351806
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/master/http/MasterDumpServlet.java:
##########
@@ -81,15 +83,15 @@ public void doGet(HttpServletRequest request,
HttpServletResponse response) thro
out.println("\n\nStacks:");
out.println(LINE);
out.flush();
- PrintStream ps = new PrintStream(response.getOutputStream(), false,
"UTF-8");
+ PrintStream ps = new PrintStream(response.getOutputStream(), false,
StandardCharsets.UTF_8);
Threads.printThreadInfo(ps, "");
ps.flush();
out.println("\n\nMaster configuration:");
out.println(LINE);
Configuration conf = master.getConfiguration();
out.flush();
- conf.writeXml(os);
+ conf.writeXml(null, os, conf);
Review Comment:
Overloading the same method to have very different security-related
behaviour is iffy, but there is nothing HBase can do about that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
