hgromer commented on code in PR #7523:
URL: https://github.com/apache/hbase/pull/7523#discussion_r2598959044


##########
hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/master/BackupLogCleaner.java:
##########


Review Comment:
   This makes sense to me. I think it's still safe given the addition of the 
new start code, and avoids WAL retention for hosts that are added to, and then 
removed from the cluster between backups. 
   
   Let me know what you think of the current implementation. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to