hgromer commented on code in PR #7523:
URL: https://github.com/apache/hbase/pull/7523#discussion_r2594066167
##########
hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/master/BackupLogCleaner.java:
##########
@@ -248,6 +241,7 @@ protected static boolean canDeleteFile(Map<Address, Long>
addressToBoundaryTs, P
private static boolean isHMasterWAL(Path path) {
String fn = path.getName();
return fn.startsWith(WALProcedureStore.LOG_PREFIX)
- || fn.endsWith(MasterRegionFactory.ARCHIVED_WAL_SUFFIX);
+ || fn.endsWith(MasterRegionFactory.ARCHIVED_WAL_SUFFIX)
+ || path.toString().contains(MasterRegionFactory.MASTER_STORE_DIR);
Review Comment:
There's a test that already exists `testCleansUpArchivedHMasterWal`. It
started failing with the code change and I realized it was a happy coincidence
of this code path
```java
if (!addressToBoundaryTs.containsKey(walServerAddress)) {
if (LOG.isDebugEnabled()) {
LOG.debug("No cleanup WAL time-boundary found for server: {}. Ok
to delete file: {}",
walServerAddress.getHostName(), path);
}
return true;
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
