apurtell commented on code in PR #7363:
URL: https://github.com/apache/hbase/pull/7363#discussion_r2448714477
##########
hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncBufferedMutatorImpl.java:
##########
@@ -90,19 +108,41 @@ public Configuration getConfiguration() {
// will be overridden in test
protected void internalFlush() {
- if (periodicFlushTask != null) {
- periodicFlushTask.cancel();
- periodicFlushTask = null;
- }
- List<Mutation> toSend = this.mutations;
- if (toSend.isEmpty()) {
- return;
+ internalFlush(FlushType.MANUAL);
+ }
+
+ protected void internalFlush(FlushType trigger) {
Review Comment:
> The only problem is the test which overrides internalFlush method. We
could try to find other ways to implement it.
Do you have a suggestion? It is your test I think :-)
Otherwise I would like to keep the test as is, and consider this an
improvement for the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
