Apache9 commented on PR #7363: URL: https://github.com/apache/hbase/pull/7363#issuecomment-3381456021
> > The implementation looks good, but we still need to consideration more about the correctness. > > @Apache9 What would you suggest here? > > I can add more test coverage. Something like this seems straightforward to implement and will not increase the running time of the test suite too much: > > Step 1: Generate a test data set of configurable size, default 100K rows. Step 2: Use ABM to commit the test data set. Step 3: Scan the test table and validate every row of the test data set has been committed. > > This will provide test coverage we don't have now, but it does not validate correctness beyond the happy path. We need to manually consider the implementation carefully, and after merging this PR, we should run ITBLL several rounds before cutting the next release. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
