Apache9 commented on code in PR #7293:
URL: https://github.com/apache/hbase/pull/7293#discussion_r2410407502
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/master/cleaner/LogCleaner.java:
##########
@@ -100,6 +100,13 @@ protected boolean validate(Path file) {
@Override
public void onConfigurationChange(Configuration conf) {
int newSize = conf.getInt(OLD_WALS_CLEANER_THREAD_SIZE,
DEFAULT_OLD_WALS_CLEANER_THREAD_SIZE);
+ if (newSize <= 0) {
+ LOG.warn(
+ "The configuration {} has been set to an invalid value {}, "
+ + "the default value {} will be used, no need to update.",
+ OLD_WALS_CLEANER_THREAD_SIZE, newSize,
DEFAULT_OLD_WALS_CLEANER_THREAD_SIZE);
Review Comment:
Oh, wait a minute, here we just return, which means we will keep the old
value, not use the default value?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
