NihalJain commented on code in PR #7293:
URL: https://github.com/apache/hbase/pull/7293#discussion_r2617990666
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/master/cleaner/LogCleaner.java:
##########
@@ -100,6 +100,13 @@ protected boolean validate(Path file) {
@Override
public void onConfigurationChange(Configuration conf) {
int newSize = conf.getInt(OLD_WALS_CLEANER_THREAD_SIZE,
DEFAULT_OLD_WALS_CLEANER_THREAD_SIZE);
+ if (newSize <= 0) {
+ LOG.warn(
Review Comment:
nit: maybe put as debug. also maybe sync with impl at
https://github.com/apache/hbase/blob/8b17149a673f7e33fc1115051a4d3435f6cf518d/hbase-server/src/main/java/org/apache/hadoop/hbase/mob/MobFileCleanerChore.java#L180
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/master/cleaner/LogCleaner.java:
##########
@@ -100,6 +100,13 @@ protected boolean validate(Path file) {
@Override
public void onConfigurationChange(Configuration conf) {
int newSize = conf.getInt(OLD_WALS_CLEANER_THREAD_SIZE,
DEFAULT_OLD_WALS_CLEANER_THREAD_SIZE);
+ if (newSize <= 0) {
+ LOG.warn(
Review Comment:
nit: maybe just put as debug. also maybe sync with impl at
https://github.com/apache/hbase/blob/8b17149a673f7e33fc1115051a4d3435f6cf518d/hbase-server/src/main/java/org/apache/hadoop/hbase/mob/MobFileCleanerChore.java#L180
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
