frostruan commented on PR #5408: URL: https://github.com/apache/hbase/pull/5408#issuecomment-3258647962
Oh, thanks for the reminder, this is indeed better. Let me address. One more word, even we move collecting regionserver wal filenum from client to master, RSRpcService still needs to provide an interface for the master to query the latest filenum. When implementing SnapshotProcedure before, I had thought about changing the signature of **RSProcedureCallable** from `public interface RSProcedureCallable extends Callable<Void>` to `public interface RSProcedureCallable<T> extends Callable<T>`, where type T is the information that can be returned to the Master after RSProcedureCallable is completed. However, considering that the Void type is enough for most RSProcedureCallables, we can consider this change in a later version. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
