Copilot commented on code in PR #5408:
URL: https://github.com/apache/hbase/pull/5408#discussion_r2317675669
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java:
##########
@@ -2083,7 +2087,6 @@ private void initializeThreads() {
// Setup the Quota Manager
rsQuotaManager = new RegionServerRpcQuotaManager(this);
Review Comment:
The removed line `configurationManager.registerObserver(rsQuotaManager);`
appears to be accidentally deleted. This registration is necessary for quota
manager configuration updates.
```suggestion
rsQuotaManager = new RegionServerRpcQuotaManager(this);
configurationManager.registerObserver(rsQuotaManager);
```
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/executor/ExecutorType.java:
##########
@@ -55,8 +55,10 @@ public enum ExecutorType {
RS_IN_MEMORY_COMPACTION(34),
RS_CLAIM_REPLICATION_QUEUE(35),
RS_SNAPSHOT_OPERATIONS(36),
+
RS_FLUSH_OPERATIONS(37),
- RS_RELOAD_QUOTAS_OPERATIONS(38);
+ RS_RELOAD_QUOTAS_OPERATIONS(38),
+ RS_LOG_ROLL(38);
Review Comment:
Both RS_RELOAD_QUOTAS_OPERATIONS and RS_LOG_ROLL have the same value (38).
RS_LOG_ROLL should have value 39 to avoid conflicts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
