wchevreuil commented on code in PR #7192:
URL: https://github.com/apache/hbase/pull/7192#discussion_r2301980456
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileReaderImpl.java:
##########
@@ -1378,7 +1379,8 @@ public HFileBlock readBlock(long dataBlockOffset, long
onDiskBlockSize, final bo
}
BlockType.BlockCategory category =
hfileBlock.getBlockType().getCategory();
final boolean cacheCompressed =
cacheConf.shouldCacheCompressed(category);
- final boolean cacheOnRead = cacheConf.shouldCacheBlockOnRead(category);
+ final boolean cacheOnRead =
Review Comment:
Ok, I think I got it now. This is probably due to the rebase on top of
master branch. Master branch had this HBASE-28596, which was missing on the
feature branch when PR #5905 was merged. So when resolving this conflict in the
rebase, I simply picked the master version.
Reading this now, seems wrong to me, we should do as PR #595 was doing. I'm
going to update it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
