wchevreuil commented on code in PR #7192:
URL: https://github.com/apache/hbase/pull/7192#discussion_r2300492200


##########
hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/TestBytesReadFromFs.java:
##########
@@ -268,6 +268,10 @@ private void readLoadOnOpenDataSection(Path path, boolean 
hasBloomFilters) throw
 
     CacheConfig cacheConfig = new CacheConfig(conf);
     HFile.Reader reader = new HFilePreadReader(readerContext, hfile, 
cacheConfig, conf);
+    // Since HBASE-28466, we call fileInfo.initMetaAndIndex inside 
HFilePreadReader,
+    // which reads some blocks and increment the counters, so we need to reset 
it here.
+    ThreadLocalServerSideScanMetrics.getBytesReadFromFsAndReset();
+    ThreadLocalServerSideScanMetrics.getBlockReadOpsCountAndReset();

Review Comment:
   Yeah, these are changes introduced in this PR last commit to fix the tests 
for HBASE-28466 changes.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to