dParikesit commented on code in PR #6970:
URL: https://github.com/apache/hbase/pull/6970#discussion_r2186466373
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/SnapshotProcedure.java:
##########
@@ -184,6 +186,12 @@ protected Flow executeFromState(MasterProcedureEnv env,
SnapshotState state)
if (isSnapshotCorrupted()) {
throw new CorruptedSnapshotException(snapshot.getName());
}
+ if (
+ SnapshotDescriptionUtils.isExpiredSnapshot(snapshot.getTtl(),
+ snapshot.getCreationTime(), EnvironmentEdgeManager.currentTime())
+ ) {
Review Comment:
I'm not sure whether this suggestion is a good idea because it is easier to
see the thrown exception directly in the caller function. What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
