Umeshkumar9414 commented on code in PR #7075:
URL: https://github.com/apache/hbase/pull/7075#discussion_r2131596677
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/wal/AbstractRecoveredEditsOutputSink.java:
##########
@@ -55,9 +55,14 @@ public AbstractRecoveredEditsOutputSink(WALSplitter
walSplitter,
/** Returns a writer that wraps a {@link WALProvider.Writer} and its Path.
Caller should close. */
protected RecoveredEditsWriter createRecoveredEditsWriter(TableName
tableName, byte[] region,
long seqId) throws IOException {
+ // If multiple worker are splitting a WAL at a same time, both should use
unique file name to
+ // avoid conflict
+ long workerStartCode =
Review Comment:
Yeah, I missed this point, this won't work.
To use the whole RS server name, I was worried about reaching the filename
lenght limit. Do you also see this concern on it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
