Apache9 commented on code in PR #7075:
URL: https://github.com/apache/hbase/pull/7075#discussion_r2131588007


##########
hbase-server/src/main/java/org/apache/hadoop/hbase/wal/AbstractRecoveredEditsOutputSink.java:
##########
@@ -55,9 +55,14 @@ public AbstractRecoveredEditsOutputSink(WALSplitter 
walSplitter,
   /** Returns a writer that wraps a {@link WALProvider.Writer} and its Path. 
Caller should close. */
   protected RecoveredEditsWriter createRecoveredEditsWriter(TableName 
tableName, byte[] region,
     long seqId) throws IOException {
+    // If multiple worker are splitting a WAL at a same time, both should use 
unique file name to
+    // avoid conflict
+    long workerStartCode =

Review Comment:
   Is startCode enough to make unique directory? Different region server could 
have same start code?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to