ajkh88 commented on code in PR #7000:
URL: https://github.com/apache/hbase/pull/7000#discussion_r2128259789
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/quotas/DefaultOperationQuota.java:
##########
@@ -288,4 +309,25 @@ private long calculateWriteCapacityUnitDiff(final long
actualSize, final long es
private long calculateReadCapacityUnitDiff(final long actualSize, final long
estimateSize) {
return calculateReadCapacityUnit(actualSize) -
calculateReadCapacityUnit(estimateSize);
}
+
+ private long calculateHandlerUsageTimeEstimate(final double
requestsPerSecond,
Review Comment:
Yes, that is pretty much it—we create the `OperationQuota` object and first
'check' it, meaning we estimate how much of the quota the operation will
consume. The quota represents different resources for different throttle types
(it could be time, space, etc.). Each quota type calculates its estimate
differently, but they are all similar in that they don’t try anything too
complicated; we just want a general idea of what will be used.
We compare our estimate to the current remaining quota, and if the estimate
would consume it all, we throw an `RpcThrottlingException` (also calculating a
wait interval here). This stops the request and backs off any retries.
If the estimate will not consume all the quota, then we 'grab', the quota -
meaning we subtract the estimate from it.
Finally, when the `OperationQuota::close` method is called, we calculate the
_actual_ time taken and update the quota accordingly, either adding to or
subtracting from it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
