ajkh88 commented on code in PR #7000:
URL: https://github.com/apache/hbase/pull/7000#discussion_r2121245360
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/quotas/DefaultOperationQuota.java:
##########
@@ -288,4 +309,25 @@ private long calculateWriteCapacityUnitDiff(final long
actualSize, final long es
private long calculateReadCapacityUnitDiff(final long actualSize, final long
estimateSize) {
return calculateReadCapacityUnit(actualSize) -
calculateReadCapacityUnit(estimateSize);
}
+
+ private long calculateHandlerUsageTimeEstimate(final double
requestsPerSecond,
Review Comment:
In this context, `handler usage time` refers to the amount of time (in
milliseconds) a handler thread will use.
We estimate the number of milliseconds we expect the thread to take to
complete the request and deduct that amount from the quota. If there are enough
milliseconds left in the quota, we proceed by taking that amount from the quota
and continuing with the request. Otherwise, we throw a throttling exception.
When the request is complete, we calculate the actual amount of time used in
the `close()` method and adjust the quota by either adding back time or further
subtracting it, as appropriate.
Does this make things clearer?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
