NihalJain commented on code in PR #139:
URL: https://github.com/apache/hbase-thirdparty/pull/139#discussion_r2106453357
##########
hbase-shaded-jetty-12-plus-core/pom.xml:
##########
@@ -218,6 +218,23 @@
</execution>
</executions>
</plugin>
+ <!-- This module relocates Jetty 12+ EE8 dependencies compiled with JDK
17, hence, overriding the project-level
+ restriction on maxJdkVersion of 'compileSource'! See HBASE-29354-->
+ <plugin>
Review Comment:
Yes we do not compile with jdk 17 here. I had even tested out most flows on
master even without this change, and things looked good.
Given we wont use these modules for branch 2, shouldnt we be fine with this?
If you think this is not an acceptable approach and we need to think deeper
on this, should I drop jetty 12 modules from our main pom temporarily? Or i
could rever the jetty change also.
We need release for branch 2.x. This is blocking the upcoming release!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
