Apache9 commented on code in PR #139:
URL: https://github.com/apache/hbase-thirdparty/pull/139#discussion_r2106389302


##########
hbase-shaded-jetty-12-plus-core/pom.xml:
##########
@@ -218,6 +218,23 @@
           </execution>
         </executions>
       </plugin>
+      <!-- This module relocates Jetty 12+ EE8 dependencies compiled with JDK 
17, hence, overriding the project-level
+      restriction on maxJdkVersion of 'compileSource'! See HBASE-29354-->
+      <plugin>

Review Comment:
   So here we do not need to compile this, just relocate the pre compiled 
.class file, which means we do not need to compile this module with JDK17 right?
   We used to relocate some jackson classes for JDK9+ too, strange that why 
there is no problem for it in the past...



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to