vinayakphegde commented on code in PR #7008:
URL: https://github.com/apache/hbase/pull/7008#discussion_r2101647344
##########
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestFSHLog.java:
##########
@@ -375,13 +375,17 @@ public void close() throws IOException {
region.put(new Put(b).addColumn(b, b, b));
log.rollWriter();
}
- assertEquals(2, log.getClosedErrorCount());
+
Review Comment:
As per the recent changes in [this
commit](https://github.com/apache/hbase/commit/059a89554636a756afcb63e4bf763b6a5e9a763a),
in FSHLog#closeWriter(), if closing the writer fails, we attempt to recover
the lease on the file. If lease recovery succeeds, we don’t retry further.
So, retries only happen if lease recovery itself fails. In this test case,
lease recovery succeeds, which is why closeErrorsCount is not incremented.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
