stoty commented on code in PR #7008:
URL: https://github.com/apache/hbase/pull/7008#discussion_r2099558255
##########
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestFSHLog.java:
##########
@@ -375,13 +375,17 @@ public void close() throws IOException {
region.put(new Put(b).addColumn(b, b, b));
log.rollWriter();
}
- assertEquals(2, log.getClosedErrorCount());
+
Review Comment:
Why do we remove this ?
##########
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestFSHLog.java:
##########
@@ -375,13 +375,17 @@ public void close() throws IOException {
region.put(new Put(b).addColumn(b, b, b));
log.rollWriter();
}
- assertEquals(2, log.getClosedErrorCount());
+
region.put(new Put(b).addColumn(b, b, b));
region.put(new Put(b).addColumn(b, b, b));
region.flush(true);
log.rollWriter();
+
+ Thread.sleep(10000);
Review Comment:
Would it make sense to use TEST_UTIL.waitFor here instead ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
