sanjeet006py commented on code in PR #6868:
URL: https://github.com/apache/hbase/pull/6868#discussion_r2058081978


##########
hbase-server/src/test/java/org/apache/hadoop/hbase/client/FromClientSideBase.java:
##########
@@ -280,6 +282,19 @@ protected Result getSingleScanResult(Table ht, Scan scan) 
throws IOException {
     return result;
   }
 
+  protected Pair<ScanMetrics, List<ScanMetrics>> getScanMetrics(Table ht, Scan 
scan)
+    throws IOException {
+    ScanMetrics scanMetrics;
+    List<ScanMetrics> scanMetricsByRegion;
+    try (ResultScanner scanner = ht.getScanner(scan)) {
+      while ((scanner.next()) != null) {

Review Comment:
   Yeah, my IDE flagged it but I couldn't see a way out. Let me spend some more 
time to see if I can consume the iterator in some way. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to