sanjeet006py commented on code in PR #6868:
URL: https://github.com/apache/hbase/pull/6868#discussion_r2058079104
##########
hbase-client/src/main/java/org/apache/hadoop/hbase/client/ScanResultConsumerBase.java:
##########
@@ -38,11 +39,22 @@ public interface ScanResultConsumerBase {
void onComplete();
/**
- * If {@code scan.isScanMetricsEnabled()} returns true, then this method
will be called prior to
- * all other methods in this interface to give you the {@link ScanMetrics}
instance for this scan
- * operation. The {@link ScanMetrics} instance will be updated on-the-fly
during the scan, you can
- * store it somewhere to get the metrics at any time if you want.
+ * If {@code scan.isScanMetricsEnabled()} returns true and
+ * {@code scan.isScanMetricsByRegionEnabled()} returns false, then this
method will be called
+ * prior to all other methods in this interface to give you the {@link
ScanMetrics} instance for
+ * this scan operation. The {@link ScanMetrics} instance will be updated
on-the-fly during the
+ * scan, you can store it somewhere to get the metrics at any time if you
want.
Review Comment:
I didn't get how this is backward incompatibility problem as current use
cases using this method will have `scanMetricsByRegionEnabled()` set to `false`
and for them `ScanMetrics` object is still tracked. For use cases which plan to
use this new feature they need to rely on new object (list of ScanMetrics).
(But I think this issue will also get solved if I extend existing
ScanMetrics to track region level metrics instead of maintaining a list of
ScanMetrics). Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
