charlesconnell commented on code in PR #6902:
URL: https://github.com/apache/hbase/pull/6902#discussion_r2054208298
##########
hbase-common/src/main/java/org/apache/hadoop/hbase/io/encoding/RowIndexSeekerV1.java:
##########
@@ -287,27 +285,43 @@ private class SeekerState {
*/
public final static int KEY_VALUE_LEN_SIZE = 2 * Bytes.SIZEOF_INT;
+ // RowIndexSeekerV1 reads one cell at a time from a ByteBuff and uses
SeekerState's fields to
+ // record the structure of the cell within the ByteBuff.
+
+ // The source of bytes that our cell is backed by
protected ByteBuff currentBuffer;
+ // Row structure starts at startOffset
protected int startOffset = -1;
- protected int valueOffset = -1;
+ // Key starts at keyOffset
+ protected int keyOffset = -1;
+ // Key ends at keyOffset + keyLength
protected int keyLength;
+ // Value starts at valueOffset
+ protected int valueOffset = -1;
+ // Value ends at valueOffset + valueLength
protected int valueLength;
+ // Tags start after values and end after tagsLength
protected int tagsLength = 0;
- protected int tagsOffset = -1;
Review Comment:
I noticed that `tagsOffset` was effectively unused so I've removed it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
