Apache9 commented on code in PR #6902:
URL: https://github.com/apache/hbase/pull/6902#discussion_r2053760462
##########
hbase-common/src/main/java/org/apache/hadoop/hbase/io/encoding/RowIndexSeekerV1.java:
##########
@@ -289,6 +288,7 @@ private class SeekerState {
protected ByteBuff currentBuffer;
protected int startOffset = -1;
+ protected int keyOffset = -1;
Review Comment:
Better add some comments to explain what do these offsets and lengths mean?
##########
hbase-common/src/main/java/org/apache/hadoop/hbase/io/encoding/RowIndexSeekerV1.java:
##########
@@ -298,7 +298,7 @@ private class SeekerState {
protected ByteBuffer keyBuffer = null;
protected long memstoreTS;
protected int nextKvOffset;
- // buffer backed keyonlyKV
+ // buffer backed keyonlyKV, reset and re-used as necessary to avoid
allocations
private ByteBufferKeyOnlyKeyValue currentKey = new
ByteBufferKeyOnlyKeyValue();
Review Comment:
Make it final if we do not need to recreate it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
