PDavid commented on code in PR #6864:
URL: https://github.com/apache/hbase/pull/6864#discussion_r2026457599
##########
hbase-rest/pom.xml:
##########
@@ -295,7 +295,7 @@
<overwrite>true</overwrite>
<resources>
<resource>
-
<directory>../hbase-server/src/main/resources/hbase-webapps/static</directory>
+
<directory>../hbase-server/target/hbase-webapps/static</directory>
Review Comment:
Many thanks, I completely agree your point that here and now we will have
and implicit dependency from hbase-rest to hbase-server which is not obvious
from first look. Also agree that this is not the best and would be better to
have an explicit dependency.
The problem is that if we directly add the webjars to the `dependencies`
section of the hbase-rest pom.xml, then those webjars will be included
(packaged) into the hbase-rest jar which - as far as I understand - we want to
avoid.
Maybe we could duplicate the `maven-dependency-plugin` (and then the copy
steps) usage also to hbase-rest but then this would introduce a lot of XML
duplication.
Other solution could be to extract the downloading and extraction of the
webjars to a separate sub-project and then hase-server, hbase-rest and
hbase-thrift could depend on it.
But I'm not a Maven expert by an means so if you have any better ideas
please feel free to propose them. :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
