NihalJain commented on code in PR #6864:
URL: https://github.com/apache/hbase/pull/6864#discussion_r2016358337
##########
hbase-rest/pom.xml:
##########
@@ -279,7 +279,7 @@
<skipAssembly>true</skipAssembly>
</configuration>
</plugin>
- <!-- Copy the static web resources (JS, CSS, images, etc.) from
hbase-server sources -->
+ <!-- Copy the static web resources (JS, CSS, images, etc.) from
hbase-server -->
Review Comment:
Hi David any reason to move js inside the main jar assembly back again? I
think this regresses requirement
[HBASE-28921](https://issues.apache.org/jira/browse/HBASE-28921) [Avoid
bundling hbase-webapps folder in default jars
(](https://github.com/apache/hbase/commit/16c51d83ac980495b18d06e0b7480c665c99275b)https://github.com/apache/hbase/pull/6388[)](https://github.com/apache/hbase/commit/16c51d83ac980495b18d06e0b7480c665c99275b)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
