Umeshkumar9414 commented on code in PR #6534:
URL: https://github.com/apache/hbase/pull/6534#discussion_r1894355718
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/wal/AbstractFSWALProvider.java:
##########
@@ -237,6 +237,9 @@ static void requestLogRoll(final WAL wal) {
/** File Extension used while splitting an WAL into regions (HBASE-2312) */
public static final String SPLITTING_EXT = "-splitting";
+ // Extension for the WAL where the split failed on one worker and is being
retried on another.
+ public static final String RETRYING_EXT = ".retrying";
+
/**
* Pattern used to validate a WAL file name see {@link
#validateWALFilename(String)} for
* description.
Review Comment:
while splitting the wal for meta table. wal name can be
rs.XXX.meta.retrying001. Do you think we should update the
[WAL_FILE_NAME_PATTERN](
#https://github.com/apache/hbase/pull/6534/files#diff-ae053c9a0d6a22213084e9ef3cddf5de6762737c10e24dc4a9d8df6a35bb5cdeR247).
Althought in splitting we didn't check for valid wal name.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
