Umeshkumar9414 commented on PR #6534:
URL: https://github.com/apache/hbase/pull/6534#issuecomment-2556826178

   > While going through the code I saw some comments and code that are not 
aligning. As per this 
[comment](https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/wal/WALSplitter.java#L185-L187),
 `WALSplitter.splitLogFile` should not be getting used in procedure based 
splitting but we are using the same method. We are calling 
`SplitLogWorker.splitLog`(that is deprecated) in `SplitWALCallable`. And inside 
this method 
[here](https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/SplitLogWorker.java#L190),
 we call `WALSplitter.splitLogFile`. Can someone help me understad this? Is 
this a miss or it is known? cc @Apache9 , @apurtell
   
   @Apache9 , @apurtell 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to