shubham-roy commented on code in PR #6435:
URL: https://github.com/apache/hbase/pull/6435#discussion_r1845765947


##########
hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/RowCounter.java:
##########
@@ -95,6 +118,36 @@ public static enum Counters {
     public void map(ImmutableBytesWritable row, Result values, Context 
context) throws IOException {
       // Count every row containing data, whether it's in qualifiers or values
       context.getCounter(Counters.ROWS).increment(1);
+
+      if (countDeleteMarkers) {
+        context.getCounter(Counters.CELLS).increment(values.size());

Review Comment:
   >as we have no way of counting when delete markers is disabled within the 
job.
   
   @NihalJain , I am not sure if I got you. However, the user can always 
control if he needs the delete markers count or not by the specifying the flag 
(--countDeleteMarkers) while triggering the job.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to