shubham-roy commented on code in PR #6435: URL: https://github.com/apache/hbase/pull/6435#discussion_r1843145736
########## hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/RowCounter.java: ########## @@ -65,22 +67,42 @@ public class RowCounter extends AbstractHBaseTool { private final static String OPT_END_TIME = "endtime"; private final static String OPT_RANGE = "range"; private final static String OPT_EXPECTED_COUNT = "expectedCount"; + private final static String OPT_COUNT_DELETE_MARKERS = "countDeleteMarkers"; private String tableName; private List<MultiRowRangeFilter.RowRange> rowRangeList; private long startTime; private long endTime; private long expectedCount; + private boolean countDeleteMarkers; private List<String> columns = new ArrayList<>(); + private Job job; + /** * Mapper that runs the count. */ static class RowCounterMapper extends TableMapper<ImmutableBytesWritable, Result> { - /** Counter enumeration to count the actual rows. */ + /** Counter enumeration to count the actual rows, cells and delete markers. */ public static enum Counters { - ROWS + ROWS, + CELLS, + DELETE, + DELETE_COLUMN, + DELETE_FAMILY, + DELETE_FAMILY_VERSION, + ROWS_WITH_DELETE_MARKER + } + + private boolean countDeleteMarkers; Review Comment: @Himanshu-g81, the variable at L98 is for the class RowCounterMapper. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org