rmdmattingly commented on code in PR #6451:
URL: https://github.com/apache/hbase/pull/6451#discussion_r1834886517
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/quotas/QuotaCache.java:
##########
@@ -436,6 +489,52 @@ private void updateQuotaFactors() {
}
}
}
+
+ private void updateMachineQuotaFactors(int rsSize) {
+ if (rsSize != 0) {
+ // TODO if use rs group, the cluster limit should be shared by the rs
group
+ machineQuotaFactor = 1.0 / rsSize;
+ }
+ }
+ }
+
+ static class RefreshableExpiringValueCache<T> {
+ private static final String DUMMY_KEY = "dummyKey";
Review Comment:
The dummy key is just an ugly way to use guava caches as a more powerful
supplier rather than a k,v function. I wrote that part before adding the
logging & name field, so didn't think about this, but that's a nice idea to
make this less ugly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
