hgromer commented on code in PR #6451:
URL: https://github.com/apache/hbase/pull/6451#discussion_r1834388250
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/quotas/QuotaCache.java:
##########
@@ -395,21 +429,40 @@ private <K, V extends QuotaState> void fetch(final String
type,
* over table quota, use [1 / TotalTableRegionNum * MachineTableRegionNum]
as machine factor.
*/
private void updateQuotaFactors() {
- // Update machine quota factor
- ClusterMetrics clusterMetrics;
- try {
- clusterMetrics = rsServices.getConnection().getAdmin()
- .getClusterMetrics(EnumSet.of(Option.SERVERS_NAME,
Option.TABLE_TO_REGIONS_COUNT));
- } catch (IOException e) {
- LOG.warn("Failed to get cluster metrics needed for updating quotas",
e);
- return;
+ boolean hasTableQuotas = !tableQuotaCache.entrySet().isEmpty()
Review Comment:
not sure if this is relevant here, but this check won't be atomic. the
contents of tableQuotaCache can change while checking userQuotaCache.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
