NihalJain commented on code in PR #6388:
URL: https://github.com/apache/hbase/pull/6388#discussion_r1816104570
##########
hbase-server/pom.xml:
##########
@@ -437,24 +438,83 @@
<skipAssembly>true</skipAssembly>
</configuration>
</plugin>
+ <plugin>
+ <groupId>org.codehaus.mojo</groupId>
+ <artifactId>build-helper-maven-plugin</artifactId>
+ <executions>
+ <execution>
+ <id>add-test-source</id>
+ <goals>
+ <goal>add-test-resource</goal>
+ </goals>
+ <phase>generate-test-sources</phase>
+ <configuration>
+ <!-- Add the hbase-webapps directory to the test resources -->
+ <resources>
+ <resource>
+ <!-- Directory containing hbase-webapps -->
+ <directory>target/${hbase.webapps.dir}</directory>
+ <!-- Target directory under test-classes -->
+ <targetPath>${hbase.webapps.dir}</targetPath>
Review Comment:
> Do we need the target directory because we compile JSPs at compile time ?
And we need target/hbase-webapps as you rightly said they are build during
compile time and generated into target directory with plugin maven-antrun-plugin
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
