NihalJain commented on code in PR #6388: URL: https://github.com/apache/hbase/pull/6388#discussion_r1816101384
########## hbase-server/pom.xml: ########## @@ -437,24 +438,83 @@ <skipAssembly>true</skipAssembly> </configuration> </plugin> + <plugin> + <groupId>org.codehaus.mojo</groupId> + <artifactId>build-helper-maven-plugin</artifactId> + <executions> + <execution> + <id>add-test-source</id> + <goals> + <goal>add-test-resource</goal> + </goals> + <phase>generate-test-sources</phase> + <configuration> + <!-- Add the hbase-webapps directory to the test resources --> + <resources> + <resource> + <!-- Directory containing hbase-webapps --> + <directory>target/${hbase.webapps.dir}</directory> + <!-- Target directory under test-classes --> + <targetPath>${hbase.webapps.dir}</targetPath> Review Comment: yes we need targetPath, otherwise the files would be copied directly as, for eg: target/test-classes/master, but we want to have: target/test-classes/hbase-webapps/master -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org