NihalJain commented on PR #6366: URL: https://github.com/apache/hbase/pull/6366#issuecomment-2413682833
> > Nice. How do we provie to ourselves that this change is correct? A diff of before and after dependency:list of each module? > > Sure, let me share the dependency tree with and without this change. mvn dependency:list - On Master: [list_master.txt](https://github.com/user-attachments/files/17377337/list_master.txt) - With BOM: [list_bom.txt](https://github.com/user-attachments/files/17377332/list_bom.txt) mvn dependency:tree - On Master: [tree_master.txt](https://github.com/user-attachments/files/17377360/tree_master.txt) - With BOM: [tree_bom.txt](https://github.com/user-attachments/files/17377340/tree_bom.txt) Skimmed the files, looks fine except the fact that maybe we should not manage `com.google.protobuf:protobuf-java` in PR: https://github.com/apache/hbase-thirdparty/pull/124 as it overrides the one coming from hadoop. Expected: [INFO] com.google.protobuf:protobuf-java:jar:2.5.0:compile -- module protobuf.java (auto) Actual: [INFO] com.google.protobuf:protobuf-java:jar:4.28.2:compile -- module com.google.protobuf [auto] > Does importing boms work this way? we can get transitivity over a series of imports? We have netty version changes as both are not in sync in master and hbase-thirdparty and this also clears the transitivity question asked earlier. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
