ndimiduk commented on code in PR #6366:
URL: https://github.com/apache/hbase/pull/6366#discussion_r1800961984
##########
pom.xml:
##########
@@ -925,13 +916,11 @@
<lz4.version>1.8.0</lz4.version>
<snappy.version>1.1.10.4</snappy.version>
<zstd-jni.version>1.5.5-2</zstd-jni.version>
- <!--
- Note that the version of protobuf shipped in hbase-thirdparty must
match the version used
- in hbase-protocol-shaded and hbase-examples. The version of
jackson-[annotations,core,
- databind] must be kept in sync with the version of
jackson-jaxrs-json-provider shipped in
- hbase-thirdparty.
+ <hbase-thirdparty.version>4.1.10-SNAPSHOT</hbase-thirdparty.version>
+ <!--Version of protobuf that hbase uses internally (we shade our pb)
+ Must match what is out in hbase-thirdparty include.
Review Comment:
Why do we need to keep `internal.protobuf.version` at all?
##########
pom.xml:
##########
@@ -1838,13 +1815,6 @@
<artifactId>netty</artifactId>
<version>${netty3.version}</version>
</dependency>
- <dependency>
- <groupId>io.netty</groupId>
- <artifactId>netty-bom</artifactId>
- <version>${netty4.version}</version>
- <type>pom</type>
- <scope>import</scope>
Review Comment:
Does importing boms work this way? we can get transitivity over a series of
imports?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
