NihalJain commented on PR #124: URL: https://github.com/apache/hbase-thirdparty/pull/124#issuecomment-2412982778
> Looks alright by me. How does it work? have you tried a PR vs. the main repo that makes use of this? Hi @ndimiduk Please refer https://github.com/apache/hbase/pull/6366 > Actually should we have logging dependencies here? Yes we can technically have all dependencies we want to keep common across our projects. Please let me know if we would like to add log4j and other logging jars over here. Also please let me know if we should evaluate other libs which can be moved to this bom, for eg: junit, mockito, hamcrest etc? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
