stoty commented on code in PR #6356:
URL: https://github.com/apache/hbase/pull/6356#discussion_r1799849007
##########
dev-support/hbase-personality.sh:
##########
@@ -233,8 +246,15 @@ function personality_modules
# tests respectively.
if [[ ${testtype} == unit ]]; then
local tests_arg=""
+
+ if [ -n "${TEST_PROFILE}" ]; then
+ extra="${extra} -P${TEST_PROFILE}"
+ else
+ extra="${extra} -PrunAllTests"
Review Comment:
The parameter parsing is already cryptic (for a bash hater like me), adding
a default value there would be even more cryptic IMO (and disturb the current
relatively easy-to read option processing pattern) .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
